Repository navigation
fix(github): normalize hostnames before credential lookup and API routing - #1069
Merged
Merged
Conversation
alandelong-oai
approved these changes
Oct 15, 2026
alandelong-oai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 320b70b with three independent source-review passes and synthesis. No P0/P1 findings were confirmed. Twenty-seven focused GitHub endpoint tests passed in the completed review. Live GitHub Enterprise and full cross-platform integration remain unvalidated.
mldangelo-oai
approved these changes
Oct 17, 2026
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Sorry it took us so long to get to this, and thank you for the contribution! Good catch on the hostname casing. I merged in main, kept the endpoint logic small, and tightened the tests around REST, GraphQL, and the hostname passed to gh auth token. Local checks and cross-platform CI are green. Happy to get this in!
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A mixed-case GitHub.com hostname could select Enterprise Server REST and GraphQL paths. Normalize the hostname before credential lookup and endpoint selection so casing does not change the selected GitHub platform.
Changes
ghchild-process regression test for the hostname used in credential lookup.Testing
build:cipassed.Risk and rollout
Compatible bug fix with no new commands, flags, or settings. Existing platform endpoints, token protections, and cancellation behavior are preserved. Endpoint tests use the real Octokit client with synthetic credentials and injected transport; live Enterprise instances were not exercised.
Public disclosure review